chore(product-assistant): speed up evaluation tests v2 #27062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoob13
changed the title
Twixes
approved these changes
Dec 19, 2024
| ) | ||
| # Apply our custom retry decorator to the test function | ||
| item.obj = retry_test_only(max_retries=3)(item.obj) | ||
| if Path(item.fspath).is_relative_to(current_dir): |
There was a problem hiding this comment.
Damn, yeah, I even checked pytest docs to make sure this only applies to this directory:
and that put me at ease so much I didn't bother checking if non-eval tests will still run 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Attempt 2. I've verified that all tests run now.
Evaluation tests are slow, so their goal is not fulfilled. Let's make them faster. It still feels slow when running all tests, but this is now ready to run in CI.
Changes
ON CLUSTERclause, which saves at least one minute of tear down.Does this work well for both Cloud and self-hosted?
No
How did you test this code?
Manual testing